[wp-trac] [WordPress Trac] #24441: Twenty Thirteen switch theme back compat missing argument

WordPress Trac noreply at wordpress.org
Tue May 28 17:14:37 UTC 2013


#24441: Twenty Thirteen switch theme back compat missing argument
---------------------------+------------------
 Reporter:  Offereins      |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.6
Component:  Bundled Theme  |     Version:  3.3
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------
Changes (by nacin):

 * milestone:  Awaiting Review => 3.6


Comment:

 This is in the back compat code that deactivates itself < 3.6, so I don't
 think it is too much to make sure it works pre-3.4.

 It could do `twentythirteen_switch_theme( $theme_name, $theme = null )`
 and then just switch to WP_DEFAULT_THEME if $theme is null. But I don't
 think twentythirteen_switch_theme() actually needs to check $theme at all.
 It can probably just switch_theme() to WP_DEFAULT_THEME. It's trying to be
 too clever — when would this code ever run when twentythirteen isn't the
 active theme?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24441#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list