[wp-trac] [WordPress Trac] #24159: Chats with spaces in the 'speaker' not parsing correctly

WordPress Trac noreply at wordpress.org
Fri May 17 16:09:01 UTC 2013


#24159: Chats with spaces in the 'speaker' not parsing correctly
------------------------------------------------------+--------------------
 Reporter:  Ipstenu                                   |       Owner:
     Type:  defect (bug)                              |      Status:  new
 Priority:  normal                                    |   Milestone:  3.6
Component:  Post Formats                              |     Version:  trunk
 Severity:  major                                     |  Resolution:
 Keywords:  needs-testing has-patch needs-unit-tests  |
------------------------------------------------------+--------------------

Comment (by aaroncampbell):

 First, [attachment:24159.2.diff] fixes this particular use case.  However,
 it only fixes it because there's an empty line between each stanza.
 Without that, chats with spaces in the usernames will still break.

 The core issue seems to be that what we're trying to handle this scenario:

 {{{
 Scott: Hey.
 I have a question: what is your favorite color?
 Nacin: Go away.
 }}}
 The problem is that while I see what we're trying to do, in almost every
 chat program "I have a question" is a valid username.  I think we're
 trying to be too smart here.

 Maybe we could check for spaces or tabs only at the beginning of the
 username?  Then we could support these without compromising spaces in
 usernames:

 {{{
 Scott: Hey.
   I have a question: what is your favorite color?
 Nacin: Go away.
 }}}

 {{{
 Scott: Hey.
         I have a question: what is your favorite color?
 Nacin: Go away.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24159#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list