[wp-trac] [WordPress Trac] #24254: Big images break side-by-side revision viewer + inconsistency when displaying images

WordPress Trac noreply at wordpress.org
Fri May 3 14:19:27 UTC 2013


#24254: Big images break side-by-side revision viewer + inconsistency when
displaying images
--------------------------+--------------------
 Reporter:  a.hoereth     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:3 ocean90]:
 > For the record: The behavior was changed in [23506] - `htmlspecialchars`
 was replaced by `wp_kses_post`.

 i don't think we want to change this back. the reason we switched to
 wp_kses_post is to allow the Diff view to show more of a WYSIWYG view -
 not an HTML/Code view.  with this patch everything goes back to source
 code, before it i see the formatting in a visual view with images and
 styles intact. if changes are made within an image code i see the source
 code.

 two options i think are better: add a 100% width as suggested, and/or
 switch to the single column view (see
 [http://core.trac.wordpress.org/attachment/ticket/23899/23899-show-
 combined-not-split-view.diff testing patch]) which is much less likely to
 have this issue.

 screenshots - before patch:

 [[Image(http://f.cl.ly/items/0p0q0827431K3u2d0B09/Screen%20Shot%202013-05-03%20at%208.10.22%20AM.jpg)]]

 after patch:

 [[Image(http://f.cl.ly/items/1J3J1m1C3g133e3d0p0B/Screen%20Shot%202013-05-03%20at%208.17.22%20AM.jpg)]]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24254#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list