[wp-trac] [WordPress Trac] #24184: Twenty Thirteen: remove fixed navbar

[WordPress Trac]

#24184: Twenty Thirteen: remove fixed navbar
---------------------------+------------------
 Reporter:  lancewillett   |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  3.6
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by celloexpressions):

 Replying to [comment:17 nacin]:
 > This is a theme that hundreds of thousands of people are going to open
 up and tear apart.
 > A default theme should be elegant... Too clever is not cool when people
 '''who are not programmers''' are going to be dissecting this theme and
 those who are programmers using it as a '''baseline''' for the next 12-24
 months.
 > it sets a particular bar: "''this'' is how you code a theme."
 I think that if the implementation of the fixed navbar is as elegant as
 possible (it seems to be pretty good), then we're giving all of these
 people a better baseline. Since this is a popular design feature at the
 moment, think of how many people will do it better using Twenty Thirteen
 as a framework than if they tried to do it from scratch. It's easy enough
 to remove, but tricky to add on. We're basically saying, with this
 particular feature: "this is how you code a fixed navbar in your theme."

 > This theme makes more than enough of a statement when it comes to
 design. Does it ''really'', ''honestly'' need this too? We're now talking
 specifically about 126 lines of not uncomplicated JavaScript, and for
 what? This is not amazing, nor is it must-have. This is scroll-to-top,
 some nifty fixed positioning, and what really just looks like a lot of
 code cruft and an over-the-top bell/whistle we couldn't part with because
 reasons.
 I think it is worth it. Especially on large monitors (>1600px), to me it
 really helps sell the experience of scrolling through all of the bands of
 color, with one small band of persistent color. Thinking about it more, it
 really is a design element more than a functional element. If it tried to
 include a menu, that probably would be "too clever." As you say, there's a
 lot of code. Maybe it's worth looking for other elements that could lose
 some, or looking for places to increase efficiency. There's not all that
 much code in this particular feature, though, for what it does design-
 wise.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24184#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software