[wp-trac] [WordPress Trac] #14045: Give the menus page an accessibility mode option, like the widgets screen.

WordPress Trac noreply at wordpress.org
Sun Mar 17 16:07:48 UTC 2013


#14045: Give the menus page an accessibility mode option, like the widgets screen.
----------------------------------------+--------------------------
 Reporter:  quanin                      |       Owner:  markjaquith
     Type:  enhancement                 |      Status:  reopened
 Priority:  normal                      |   Milestone:  3.6
Component:  Accessibility               |     Version:  3.0
 Severity:  normal                      |  Resolution:
 Keywords:  3.6-menus has-patch commit  |
----------------------------------------+--------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:57 GaryJ]:
 > In [23727], the variable in nav-menu.js is
 `menu.oneThemeLocationNoMenus`, yet the localized object is `menus`,
 making the property `menus.oneThemeLocationNoMenus`.

 Fixed the object name, but then got strange results: all the items from
 Pages meta box were copied to the menu without my intention. I already had
 two menus, so `oneThemeLocationNoMenus` should have been false.

 It occured to me that `'false'` as a string (in `wp-admin/nav-menus.php`,
 line 358) still evaluates as true, which I guess caused this.

 lessbloat, could you confirm that
 [attachment:14045.oneThemeLocationNoMenus.diff] works as intended?

 [attachment:14045.6.diff] is the combined patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14045#comment:58>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list