[wp-trac] [WordPress Trac] #23317: Featured Image able to be set before image processed

WordPress Trac noreply at wordpress.org
Sat Mar 2 21:43:11 UTC 2013


#23317: Featured Image able to be set before image processed
--------------------------+--------------------
 Reporter:  bobbravo2     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.5.2
Component:  Media         |     Version:  3.5.1
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+--------------------

Comment (by kadamwhite):

 If any attachments within the current selection have not finished
 uploading, then the submit button will fail in both the "Insert Media"
 frame and the "Set Featured Image" media frame. The extra ghost attachment
 item is just a side-effect of the weird state you get by trying to set the
 featured image when the attachment's data isn't available.

 After speaking with Helen, we feel it makes sense to disable the submit
 button if any image within the current selection has not yet finished
 uploading. This will prevent the unexpected behavior of clicking the
 "insert" button and seeing no action, as well as preventing the creation
 of the empty extra Attachment model.

 CrazyJaco & I have a patch for this, attached above. We are using _.map to
 get a list of the uploading state of all models within the collection,
 then identifying whether any of those uploads are still in progress with
 _.some.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23317#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list