[wp-trac] [WordPress Trac] #24627: Fatal error in wp-admin/setup-config.php

[WordPress Trac]

#24627: Fatal error in wp-admin/setup-config.php
-----------------------------+-----------------------
 Reporter:  SergeyBiryukov   |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  high             |  Milestone:  3.6
Component:  Upgrade/Install  |    Version:  trunk
 Severity:  blocker          |   Keywords:  has-patch
-----------------------------+-----------------------
 There's a fatal error in `wp-admin/setup-config.php` when creating `wp-
 config.php` via the web interface.

 Introduced in [24480] and [24482]. [24497] added a `function_exists()`
 check for `wp_kses_bad_protocol()`, since it's not available in `setup-
 config.php`. However, as
 [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2013-06-22&sort=asc#m631755 noted by markoheijnen in IRC],
 `wp_http_validate_url()` calls `esc_url()`, which in turn calls
 `wp_kses_bad_protocol()` too, so `wp_http_validate_url()` should also be
 wrapped in the `function_exists()` check.

 In 3.5.2 `reject_unsafe_urls` is false by default, so
 `wp_http_validate_url()` is not called, and there's no error.
 Even if a mu-plugin changes `reject_unsafe_urls` to true, plugins are not
 loaded in `setup-config.php`.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24627>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software