[wp-trac] [WordPress Trac] #24595: Twenty Thirteen: Load Genericons in a More Plugin-friendly Way

WordPress Trac noreply at wordpress.org
Fri Jun 21 00:54:47 UTC 2013


#24595: Twenty Thirteen: Load Genericons in a More Plugin-friendly Way
------------------------------+------------------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Bundled Theme     |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |
------------------------------+------------------------------

Comment (by Ipstenu):

 I don't think Genericons should be in core (and I'm not just saying that
 as the author of a plugin that brings 'em in). Dashicons makes sense, it's
 actually a part of WordPress Core. Genericons, and Font-Awesome, and all
 other fonts for that matter that are used on the front end of WP are
 subjective and don't belong in core. But... Realistically this is the same
 struggle anyone faces when a theme includes a font that a plugin does as
 well, and perhaps a better way to look at this is more ... generically.

 "How can we make it easier to include fonts (be they font icons or regular
 ones) in a way that a plugin and a theme that both include it don't stop
 all over each other?"

 Now if TwentyThirteen 'called' genericons instead of bundling all the CSS
 inline in wp-content/themes/twentythirteen/style.css, then yeah, that'd be
 easier :) But it only works as far as I know someone else is using the
 code. If devs aren't consistent in the naming, we hit the same problem
 problem faced with jquery files that aren't in code that people pull in
 via plugins. Even if we use  {{{wp_enqueue_style('genericons')}}} there's
 no promise that Dudley Do-Right won't use {{{wp_enqueue_style('dudley-
 genericons')}}} instead, thus double loading again.

 FWIW, I ran the Genericon'd plugin on TwentyThirteen for about a month
 without any conflicts, though perhaps not the best speed ;)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24595#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list