[wp-trac] [WordPress Trac] #24826: Add __construct function to the "WP_Comment_Query" Class

WordPress Trac noreply at wordpress.org
Sun Jul 28 22:02:04 UTC 2013


#24826: Add __construct function to the "WP_Comment_Query" Class
------------------------------------------------+--------------------------
 Reporter:  ramiy                               |       Owner:
     Type:  enhancement                         |      Status:  new
 Priority:  normal                              |   Milestone:  Awaiting
Component:  Comments                            |  Review
 Severity:  normal                              |     Version:  trunk
 Keywords:  2nd-opinion dev-feedback has-patch  |  Resolution:
------------------------------------------------+--------------------------
Changes (by westonruter):

 * cc: weston@… (added)
 * keywords:  needs-patch 2nd-opinion dev-feedback => 2nd-opinion dev-
     feedback has-patch
 * version:  3.1 => trunk
 * severity:  major => normal


Comment:

 Add `WP_Comment_Query::__construct()` for parity with
 `WP_Query::__construct()`

 Also:
 Add `WP_Comment_Query::get_comments()` for parity with
 `WP_Query::get_posts()`
 Add `WP_Comment_Query::$comments` for parity with `WP_Query::$posts`
 Declare `WP_Comment_Query::$query_vars` which was previously implicit

 Relates to #15032

 Patches are also on GitHub at:
 https://github.com/x-team/WordPress/tree/24826
 https://github.com/x-team/WordPress/commit/db6105cbaf60ca20501fafea29b0f8277ed03cd3

 Passes unit tests for comment group; also added a new test for the changes
 to WP_Comment_Query (attached).

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24826#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list