[wp-trac] [WordPress Trac] #24212: Add missing inline docs for esc_attr_x() and esc_html_x()

WordPress Trac noreply at wordpress.org
Sun Jul 28 20:54:05 UTC 2013


#24212: Add missing inline docs for esc_attr_x() and esc_html_x()
--------------------------+------------------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Inline Docs   |     Version:  2.8
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by fjarrett):

 * cc: fjarrett@… (added)
 * keywords:  needs-patch easy-fix => has-patch


Comment:

 OK I've added inline docs to both functions.

 I also spotted an inconsistency with the first argument being named
 `$single` which does not match what is used in similar functions nor does
 it even match what is in the Codex.

 http://codex.wordpress.org/Function_Reference/esc_attr_x
 http://codex.wordpress.org/Function_Reference/esc_html_x

 So in this patch, I've updated the first argument in both functions to
 correctly use the var name `$text`.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24212#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list