[wp-trac] [WordPress Trac] #24202: Self-explanatory argument values for new media functions

WordPress Trac noreply at wordpress.org
Fri Jul 12 19:55:09 UTC 2013


#24202: Self-explanatory argument values for new media functions
------------------------------------+--------------------
 Reporter:  SergeyBiryukov          |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  high                    |   Milestone:  3.6
Component:  Media                   |     Version:  trunk
 Severity:  major                   |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+--------------------

Comment (by nacin):

 What's left here is I am not a huge fan of get_images_in_content(). While
 get_media_embedded_in_content() is fairly simple and straightforward,
 get_images_in_content() is pretty complicated and covers a bunch of
 different scenarios. On one hand, that's good. On the other, this feels
 like it has the potential to feel inferior in the future. Given galleries,
 featured images, and attached images, we already have quite a bit of
 association. I'm just not quite sure what this helps with right now.

 Maybe if we dropped caption handling?

 Dropping them entirely would also remove a few more $html = true
 parameters. (I'd like to rename these to $raw_html = true.)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24202#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list