[wp-trac] [WordPress Trac] #16843: wp_unique_post_slug() doesn't check pagination base when CPT has archive

WordPress Trac noreply at wordpress.org
Mon Jul 8 13:52:05 UTC 2013


#16843: wp_unique_post_slug() doesn't check pagination base when CPT has archive
--------------------------------------------------+------------------
 Reporter:  scribu                                |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  3.6
Component:  Post Types                            |     Version:  3.1
 Severity:  minor                                 |  Resolution:
 Keywords:  has-patch 3.3-early needs-unit-tests  |
--------------------------------------------------+------------------
Changes (by nacin):

 * keywords:  has-patch 3.3-early => has-patch 3.3-early needs-unit-tests


Comment:

 Some proper unit tests would be great here.

 I'm seeing `preg_match( "@^($wp_rewrite->pagination_base)?\d+$@", $slug )`
 for hierarchical post types, is that not necessary here?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/16843#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list