[wp-trac] [WordPress Trac] #23450: Refactor menu item meta boxes as accordion

WordPress Trac noreply at wordpress.org
Mon Jul 8 13:26:08 UTC 2013


#23450: Refactor menu item meta boxes as accordion
---------------------------------------------+--------------------------
 Reporter:  lessbloat                        |       Owner:  markjaquith
     Type:  task (blessed)                   |      Status:  reopened
 Priority:  normal                           |   Milestone:  3.6
Component:  Menus                            |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  3.6-menus has-patch needs-codex  |
---------------------------------------------+--------------------------

Comment (by nacin):

 So:
  * Let's ignore the customizer classes.
  * I don't think we need to DRY this for now. It ends up less readable,
 and it's late in the cycle to refactor.

 I think the only thing we need to worry about is:
  * I will mention that 'sorted' is used in do_accordion_sections() as a
 priority to look at — but this must stay (and should be probably
 commented) in case do_meta_boxes() has done sorting on that page in some
 other situation.

 As in, let's make sure the functions share the same code with regards to
 sorting.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23450#comment:47>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list