[wp-trac] [WordPress Trac] #23255: get_post_format() can throw PHP notice and doesn't return WP_Error

WordPress Trac noreply at wordpress.org
Tue Jan 22 06:33:27 UTC 2013


#23255: get_post_format() can throw PHP notice and doesn't return WP_Error
--------------------------+------------------
 Reporter:  azaozz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by nacin):

 The WP_Error bit appears to be a documentation issue. This function
 already has multiple error conditions that return false, and none that
 return WP_Error. By suddenly adding return values of WP_Error that already
 had scalar return values, we risk fatal errors during usage. Overall, not
 a good idea.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23255#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list