[wp-trac] [WordPress Trac] #3782: Use Digraphs for Umlauts in German Permalinks

[WordPress Trac]

#3782: Use Digraphs for Umlauts in German Permalinks
------------------------------+------------------------
 Reporter:  transalpin        |       Owner:  anonymous
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  3.6
Component:  I18N              |     Version:  2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------------

Comment (by nacin):

 Looks quite solid. Three things:

 Probably no need to ever call get_locale() if ! seems_utf8().

 I wonder if array_merge() is particularly slow or inefficient here, as
 this isn't a small array. The union operator (+) has a bit less overhead,
 as might just adding on the individual key/value pairs.

 I would tend to agree that A should become Ae, not AE. remove_accents()
 does follow the same uppercase pattern elsewhere in the file. Since this
 is a language-specific rule, I am not too worried about the inconsistency.
 Note the only other usage of remove_accents() beyond permalinks, is
 sanitize_user(), which does not enforce strtolower (it used to in
 multisite).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/3782#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software