[wp-trac] [WordPress Trac] #23190: get_user_id_from_string() is returning wrong data

[WordPress Trac]

#23190: get_user_id_from_string() is returning wrong data
---------------------------+------------------------------
 Reporter:  godhulii_1985  |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Multisite      |     Version:  3.5
 Severity:  normal         |  Resolution:
 Keywords:  close          |
---------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-codex => close


Comment:

 `get_user_id_from_string()` was introduced in
 [http://mu.trac.wordpress.org/ticket/884 mu:884] and inherited during the
 merge: [12603].

 Replying to [comment:4 scribu]:
 > We should just document that `get_user_id_from_string( $x )` will return
 $x, if $x is numeric.

 I've added a note to both Codex articles: [[BR]]
 http://codex.wordpress.org/WPMU_Functions/get_user_id_from_string [[BR]]
 http://codex.wordpress.org/Function_Reference/get_user_id_from_string
 [[BR]]

 We could also add a note to the inline docs ([attachment:23190.patch]),
 but I guess we should just replace the only instance of
 `get_user_id_from_string()` in core with `get_user_by()` (#23192) and then
 deprecate the former in favor of latter.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23190#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software