[wp-trac] [WordPress Trac] #23119: UI Improvements to nav-menus.php

WordPress Trac noreply at wordpress.org
Thu Jan 10 23:29:33 UTC 2013


#23119: UI Improvements to nav-menus.php
-------------------------------------+------------------
 Reporter:  lessbloat                |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  3.6
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by jkudish):

 * keywords:   => has-patch needs-testing


Comment:

 [http://core.trac.wordpress.org/attachment/ticket/23119/23119.15.diff
 23119.15.diff] builds upon 23119.14.diff and converts the "hacked up"
 table into a proper `WP_List_Table`, which gives it several features:

 * search
 * items per page + paging
 * cleaner code to maintain / easier extendability

 Here's how it looks now. Note that I chose that location for the search
 bar because I thought it would be a better spot for it vs. above the
 table. Up for debate of course.

 [[Image(http://core.trac.wordpress.org/raw-
 attachment/ticket/23119/Screen%20Shot%202013-01-10%20at%203.16.42%20PM.png)]]

 Implementation notes:

 I pretty much went with an approach of the least modified code possible to
 integrate the `WP_List_Table`. There's definitely more work to be done:

 * I suggest we split the two tabs into 2 separate files, this will allow
 us to cut down on the amount of logic/if statements to display the
 different UI elements and will make updates easier
 * There's cleanup to be done with some (now) old code, assuming core
 adopts this new UI.

 Thoughts so far?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23119#comment:70>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list