[wp-trac] [WordPress Trac] #17689: Terms should not be sanitized inside term_exists()

WordPress Trac noreply at wordpress.org
Wed Jan 9 23:02:06 UTC 2013


#17689: Terms should not be sanitized inside term_exists()
----------------------------------------+------------------
 Reporter:  blepoxp                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  3.6
Component:  Taxonomy                    |     Version:  3.2
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+------------------
Changes (by wonderboymusic):

 * keywords:  has-patch needs-unit-tests needs-refresh => has-patch needs-
     unit-tests


Comment:

 I attacked `sanitize_title_with_dashes()` here as well #17648

 I refreshed my patch for this ticket. With it, you can no longer add $$$
 an endless number of times, and M- and M+ become m-minus and m-plus in
 slug form. This way be controversial, but my thinking (and RegEx logic)
 are this:

 - If you enter {Not - or +}{+ or -}{space}, this is an intentional use of
 "plus" or "minus" e.g. A+ Effort
 - If your term name ENDS in {Not - or +}{+ or -}, same goes = e.g. A+

 These satisfy comment:6 and all Unit Tests pass. If we go with this patch,
 #22023 is no longer blocked.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17689#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list