[wp-trac] [WordPress Trac] #23295: Improved login expiration warning

[WordPress Trac]

#23295: Improved login expiration warning
-------------------------------------------------+------------------
 Reporter:  mintindeed                           |       Owner:
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  3.6
Component:  Autosave                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  autosave-redo has-patch ui-feedback  |
-------------------------------------------------+------------------
Changes (by mintindeed):

 * keywords:  autosave-redo => autosave-redo has-patch ui-feedback


Comment:

 Updated patch to address items discussed in #wordpress-dev

 The major items are:
 * Removed reliance on Thickbox, allows simplification of the JS and looks
 a little nicer
 * Heartbeat response now returns the HTML for the modal dialogue

 I've gone back and forth a little bit on how to display the modal dialogue
 and whether to use an overlay.  Second opinions here are welcome.  Here's
 my rationale for what I've done in the patch:

 * Disabling critical buttons (save, publish, trash, etc) instead of using
 an overlay, because one of the more common use-cases is: this dialogue
 pops up while typing in a post.  Not using an overlay seems like it's less
 jarring in this context, doesn't interrupt typing, and still presents the
 nice big notice to the user.
 * I made the modal dialogue bigger, so it no longer needs to resize to fit
 the interim login iframe.  The "growing" animation is kinda sexy, but a
 larger dialogue window is a lot more noticeable.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23295#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software