[wp-trac] [WordPress Trac] #23119: UX Improvements to nav-menus.php

[WordPress Trac]

#23119: UX Improvements to nav-menus.php
-----------------------------------------------+------------------
 Reporter:  lessbloat                          |       Owner:
     Type:  enhancement                        |      Status:  new
 Priority:  normal                             |   Milestone:  3.6
Component:  Menus                              |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch needs-testing 3.6-menus  |
-----------------------------------------------+------------------

Comment (by lessbloat):

 AaronCampbell did a quick at-a-glance code review, and found the
 following:

 * Looks like an accidental replacement of @uses with wp_n in the doc block
 * There's some commented out code in wp-admin/includes/nav-menu.php that
 should probably be removed instead of commented
 * There's a small amount of trailing whitespace, which should be removed
 * There are some strings that aren't translatable in wp-admin/nav-
 menus.php on line 451 (Menus, and Add New) and one line 483 (Go).  There
 may be more, but those are the ones I saw
 * In wp-admin/nav-menus.php on line 464 you're using esc_html in an
 attribute.  Use esc_attr instead.  This could happen other places, this is
 the one I noticed

 Which I fixed in 23119.29.1.diff​.

 Additional code reviews would be much appreciated (from multiple people).
 Thanks for your help!

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23119#comment:196>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software