[wp-trac] [WordPress Trac] #26728: Previous fix for get_queried_object, gives notices for tax queries

WordPress Trac noreply at wordpress.org
Fri Dec 27 18:30:03 UTC 2013


#26728: Previous fix for get_queried_object, gives notices for tax queries
--------------------------+--------------------
 Reporter:  layotte       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.8.1
Component:  Query         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by layotte):

 Replying to [comment:10 SergeyBiryukov]:
 > Replying to [comment:5 layotte]:
 > > If $this->is_tax is always true, than the line 3265 above will always
 be true:
 >
 > No, it's vice versa. If we're inside that condition, then either
 `$this->is_category`, `$this->is_tag`, or `$this->is_tax` is true. We
 check for `$this->is_category` and `$this->is_tag` above, so if they are
 both false, that means `$this->is_tax` is true.

 Ah, yes, misunderstood what he meant.

 +1 to 26728.diff

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26728#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list