[wp-trac] [WordPress Trac] #25853: Changeset 25696 breaks expected value of argument sent to filter 'retrieve_password_message'

WordPress Trac noreply at wordpress.org
Tue Dec 3 21:10:11 UTC 2013


#25853: Changeset 25696 breaks expected value of argument sent to filter
'retrieve_password_message'
--------------------------+-----------------------------
 Reporter:  dcavins       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Users         |     Version:  3.7
 Severity:  minor         |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+-----------------------------
Changes (by nacin):

 * milestone:  3.7.2 => Future Release


Comment:

 Right, I figured that sending the existing plain-text key through the
 filter would break the least. Happy to add the hashed value as a new
 argument.

 I don't think this actually broke anything. Did it? Anyone doing raw
 queries on the DB is going to have a bad time with this change no matter
 what. This was about the email message being sent, not any complex
 operations.

 I'm OK with passing the hashed value, but it seems like passing the user's
 login (or rather, ID or a user object) might make more sense.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25853#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list