[wp-trac] [WordPress Trac] #25160: Unnecessarily passing $this by reference in core

WordPress Trac noreply at wordpress.org
Wed Aug 28 15:16:38 UTC 2013


#25160: Unnecessarily passing $this by reference in core
-------------------------------------+------------------------------
 Reporter:  jdgrimes                 |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  General                  |     Version:
 Severity:  trivial                  |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by wonderboymusic):

 To make this patch as committable as possible, I would break it into 2
 patches:

 1. removing the instances of `&$this` when present in a `callable` -
 meaning `array( &$this, 'foo' )`

 2. Everything else - the `*_ref_array()` stuff - which may need more
 testing

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25160#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list