[wp-trac] [WordPress Trac] #25094: Twenty Fourteen: Audit Theme Customization Options

[WordPress Trac]

#25094: Twenty Fourteen: Audit Theme Customization Options
------------------------------+------------------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Bundled Theme     |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |
------------------------------+------------------------------

Comment (by cainm):

 I see no reason to have the ability to hide the header text

   If the header text color is customizable, that color control should
 change all of the white text in the navbar, sidebar, and footer (ie, it
 shouldn't be a header text control)

 Both of these are core features, and good examples of how to use them.
 There are a number of use cases for both, but specifically for the first,
 a user may want to set a custom header with a logo and remove the
 redundant header text.

 As far as the header text color goes, I don't think we should be
 automatically setting all header/sidebar links the same color as the
 header - a user might just want their site title to be a different color.

   So, do we really want the custom header feature at all? Having the
 header itself requires us to use $( window ).on('scroll' ... JS, which is
 laggy and one of the reasons we removed the fixed navbar in Twenty
 Thirteen

 The fixed header adds a lot to the design of this theme. I believe the
 removal of Twenty Thirteen's fixed navbar came down to just a lack of
 support ''for'' keeping it, not necessarily concern about the speed of the
 JS. I vote to keep the header.

   Do we really need a custom background feature? This is more necessary
 since we're not doing #25013 (one of the reasons I wanted to do that). For
 the sake of simplicity, would a custom background color, but not image, be
 sufficient, since the background is only in the right margin?

 Another good implementation of a core feature. I think that not fixing
 #25013 should be a vote in support of leaving the custom background
 feature, since larger viewports will be able to see this area.

   The "Theme Options" section should be renamed to something like "social
 links". But is it a theme's position to specify these? Even when switching
 to a child theme, they need to be re-entered. This seems like plugin or
 maybe core territory.

 Although I agree that Social Link functionality could be pulled out into a
 plugin, one doesn't exist yet, and the social links in the connect bar are
 a nice addition to the theme. Vote to leave unless a core plugin is
 started.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25094#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software