[wp-trac] [WordPress Trac] #16944: Add new 'bynetworkuser' CSS class to output from comment-template.php

WordPress Trac noreply at wordpress.org
Tue Aug 20 11:41:30 UTC 2013


#16944: Add new 'bynetworkuser' CSS class to output from comment-template.php
-----------------------------+-----------------------
 Reporter:  jacques_chester  |       Owner:
     Type:  enhancement      |      Status:  reopened
 Priority:  normal           |   Milestone:  3.7
Component:  Comments         |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+-----------------------

Comment (by nacin):

 Replying to [comment:8 johnbillion]:
 > Need to keep an eye on the performance impact of adding this in. The
 patch adds a call to `is_user_member_of_blog()` to every comment, which
 calls `get_blog_details()` for every blog that the user is a member of.

 This is really expensive. The alternatives are to call get_users() to get
 all members of the blog, or to trigger a usermeta fetch. Either one is
 pretty heavy — all for a CSS class that can be conditionally added by a
 filter. While the class is cool, implementing it is doable in a plugin as
 needed. Strongly suggesting wontfix.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/16944#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list