[wp-trac] [WordPress Trac] #23756: make_clickable should not convert the URLs in pre, code tags

[WordPress Trac]

#23756: make_clickable should not convert the URLs in pre,code tags
------------------------------------------------------+--------------------
 Reporter:  alex-ye                                   |       Owner:
     Type:  defect (bug)                              |      Status:  new
 Priority:  normal                                    |   Milestone:  3.7
Component:  Formatting                                |     Version:  3.5.1
 Severity:  normal                                    |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-tests  |
------------------------------------------------------+--------------------

Comment (by helen):

 I WROTE A UNIT TEST YOU GUYS. [attachment:23756.test.diff]

 Looking at jjj's patch, it seemed to me that nesting them would break
 things, as in it would end the $in_code flag early, which does seem to be
 the case. The last test fails; however, I'm not sure that you're supposed
 to have a `code` element inside `pre` unless it wraps everything as well,
 e.g. `<pre><code>blah</code></pre>`. See http://www.w3.org/TR/html5
 /grouping-content.html#the-pre-element

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23756#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software