[wp-trac] [WordPress Trac] #18242: Changing domain for a network blog make faulty changes in database

WordPress Trac noreply at wordpress.org
Tue Aug 13 13:36:19 UTC 2013


#18242: Changing domain for a network blog make faulty changes in database
------------------------------------+------------------
 Reporter:  darkwhispering          |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.7
Component:  Multisite               |     Version:  3.0
 Severity:  major                   |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by nacin):

 I've run into this as well. get_blogaddress_by_domain() seems pretty lame
 and should probably just get axed once it is no longer used here.

 Not sure why one patch checks HTTP_HOST. The other patch seems sufficient
 — but I'll note that should be esc_url_raw().

 It seems like the changes in [12978] shouldn't have happened. Maybe ryan
 has some ideas. A straight update_option() makes the most sense — the
 original check occurring before [12978] was unnecessary anyway as
 update_option() would have handled the equals comparison.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/18242#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list