[wp-trac] [WordPress Trac] #22959: Show all roles in user list table

WordPress Trac noreply at wordpress.org
Wed Aug 7 22:42:38 UTC 2013


#22959: Show all roles in user list table
-----------------------------+------------------
 Reporter:  scribu           |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  3.7
Component:  Role/Capability  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------
Changes (by DrewAPicture):

 * cc: xoodrew@… (added)
 * milestone:  Future Release => 3.7


Comment:

 Replying to [comment:11 JustinSainton]:
 > Refreshed against trunk, added inline docs, added filter for
 get_role_str method.  Not über-sold on the filter name, but it definitely
 feels like a filter worth having.

 Not really sold on the function name either. And since the filter is
 evaluated on the return, it should match the function name.

 [attachment:22959.3.diff]:
 * Changes the function/filter name to `get_role_list()|get_role_list`
 * Accounts for back-compat on role-named classes on single row checkboxes
 * Fleshes out the doc block.

 Side note: Is it kosher to just remove the `$role` param from the method
 in this type of context? Just curious.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22959#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list