[wp-trac] [WordPress Trac] #23831: Insert Into Post for Audio / Video doesn't always work

[WordPress Trac]

#23831: Insert Into Post for Audio / Video doesn't always work
------------------------------+--------------------
 Reporter:  wonderboymusic    |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.6
Component:  Post Formats      |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+--------------------

Comment (by wonderboymusic):

 attachment:23831.2.diff​ enforces dimensions for video, when present, in
 all cases. The post format meta for video is now a shortcode, so the
 dimensions don't have to be looked up on the fly. For audio and video, the
 meta can be an attachment id, url, HTML embed code, or a shortcode

 Introduces `attachment_url_to_postid()` which will try to convert a URL
 containing a `home_url()` front into post ID by looking at the `guid`
 column for an attachment in the posts table

 The issue Otto brought up, which is the original reason for this ticket,
 still exists. The question is: should the content change for Insert Into
 Post for audio or video when the user selects the `custom`, `file`, `post`
 or `none` URL option. As it stands, all insert the proper shortcode, there
 is no difference based on that selection

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23831#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software