[wp-trac] [WordPress Trac] #22044: Twenty Twelve: Support Media Queries on IE7/8 (don't use mobile menu)

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 28 19:57:23 UTC 2012


#22044: Twenty Twelve: Support Media Queries on IE7/8 (don't use mobile menu)
-----------------------+---------------------------
 Reporter:  bpetty     |       Type:  defect (bug)
   Status:  new        |   Priority:  normal
Milestone:  3.5        |  Component:  Bundled Theme
  Version:  trunk      |   Severity:  major
 Keywords:  has-patch  |
-----------------------+---------------------------
 The issue of IE7/8 using the mobile version of the menu (see #21440) is
 caused by the stylesheet defining mobile styles as the default, and
 overriding those in media queries for desktop screen sizes, but since
 IE7/8 don't support media queries, they only use the mobile styles.

 Having [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2012-09-28&sort=asc#m467426 discussed this in IRC] with
 lancewillet and mattwiebe for a bit, there's some that believe that
 "mobile first" design (used for Twenty Twelve) forces the stylesheet to
 define mobile screen styles as the default non-media-query-supporting
 styles before defining desktop screen styles within media queries.

 Even though I still don't believe that is true, it's really too late to
 change that now anyway with Twenty Twelve now up on Extend. So instead,
 I'm proposing that this can still be fixed without changing the stylesheet
 at all by using this hack which conditionally includes a JS library that
 adds fake support for media queries for browsers that don't support it:

 * [http://code.google.com/p/css3-mediaqueries-js/ css3-mediaqueries.js]

 I think this was a huge oversight to assume that it would just be fine to
 show the mobile version of the menu on IE7/8, and we already had bug
 reports coming in before Beta 1 was even released. I know that with over
 30% of all desktop users still using IE7/8, this will be an ongoing
 problem with duplicate reports constantly coming in if it is not fixed.

 I have tested this on IE8, and it does indeed fix the menu, and seems to
 work well. As an added bonus, IE7 and IE8 are also now actually responsive
 too.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22044>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list