[wp-trac] [WordPress Trac] #21456: Replace animated spinner gifs

[WordPress Trac]

#21456: Replace animated spinner gifs
----------------------------+------------------------
 Reporter:  nacin           |       Owner:  lessbloat
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  3.5
Component:  UI              |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------------

Comment (by lessbloat):

 Couple improvements in 21456.4.diff:

 Replying to [comment:20 nacin]:
 > The reason why visibility: hidden is often used instead of display: none
 is because then the spinner takes up space. When toggling the display
 property, we've often seen other objects move around, which can be jarring
 and certainly not expected behavior. So it is definitely safer to use
 visibility.
 >


 '''With the new spinners using float, this should no longer be necessary.
 They should all work with display: none.  Please let me know if you see
 some place where there is any movement, and I'll fix it.'''


 > I'd like to do either a 'visible' class or an 'active' class. Then
 show() and hide() can be add/toggle/removeClass. Better then
 css('visibility', value), that's for sure.
 >


 '''Can this be a v2 objective.  This patch already spans quite a few
 files. :-)'''


 > Looking at [attachment:21456.3.diff], I'm seeing a lot of brokenness.
 Not your fault — we basically rolled our own spinner code for quite a long
 time. This is unfortunately way more than just a find-and-replace
 operation. Also, the spinners on options-general.php aren't unused.
 >


 '''I went through each spinner one by one and tested them in several
 browsers.  I made a spreadsheet with the status of each:
 https://docs.google.com/spreadsheet/ccc?key=0Av7nMZXUOf52dExvVXBKZE8tbHFJWVRBck9kQkJxd3c#gid=0
 There are still a couple that I need some help figuring out.  Again,
 please also report any additional bugs that you spot, and I'll fix
 them.'''


 > I suggest we introduce .spinner, then start to use it wherever we can.
 Each instance will need to be confirmed (which is not fun or easy) as
 being not broken style-wise. A decent amount of CSS classes (.waiting,
 .ajax-loading) can probably vanish, and some JS could probably be cleaned
 up.
 >


 '''Done. Still need to do this for the spinners in the spreadsheet that
 I've been unable to test.'''

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21456#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software