[wp-trac] [WordPress Trac] #21749: Wrong URL for theme screenshot

[WordPress Trac]

#21749: Wrong URL for theme screenshot
--------------------------+--------------------
 Reporter:  pavelevap     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4.2
Component:  Themes        |     Version:  3.4.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by nacin):

 Reviewed these again.
  * ms-themes list table is almost exclusively sending an unencoded
 stylesheet through wp_nonce_url(), which will get it encoded. The only
 exception is wp-admin/themes.php, which happens to be a '''regression'''.
  * The old-school preview links in class-wp-upgrader need urlencoded
 stylesheet values. This is a '''regression''', though the Live Preview
 (fixed by [21713]) replaces these links in most situations.
  * The network enable link in class-wp-upgrader goes through
 wp_nonce_url(), which will encode it, so it is not broken.
  * In wp-admin/includes/theme.php (delete_theme()), this goes through
 wp_nonce_url(), so it is not broken.
  * The decoding in theme-editor.php is not intentional and should be
 removed, but does not break anything.

 For 3.4: Merge [21713] to the branch. [21712] is already merged, see
 [21714]. Fix links in the upgrader. Ignore the "Edit" link in ms-themes.

 For 3.5: Make sure all of [attachment:21749.diff] makes it in, rather than
 relying on wp_nonce_url() to do the work.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21749#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software