[wp-trac] [WordPress Trac] #21740: Twenty Twelve: Review overflow attributes

WordPress Trac wp-trac at lists.automattic.com
Sat Sep 1 14:05:22 UTC 2012


#21740: Twenty Twelve: Review overflow attributes
---------------------------+------------------
 Reporter:  obenland       |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------

Comment (by obenland):

 I'd like to '''remove''' the attribute from the following selectors:

 * `.widget-area .widget`: Maybe change that, so that floats could still be
 used in text widgets. But other than that it seems not to be needed here.
 Plus it kills the bottom-shadow of the 'Search' button.

 * `footer[role="contentinfo"]`: Nothing floats in the footer.

 * `.image-attachment`: Let's move the overflow attribute to
 `article.attachment`, so the image shadow does not get cut off.

 * `.comments-meta article`: Doesn't have any effect. And while we're
 there: `.comments-area article p` is redundant.

 * `#respond form p`: Nothing floating there either, but causing above
 mentioned bug

 I'd like to '''add''' the attribute to the following selector:

 * `.entry-content`:  We pass the "Clearing Floats" Unit Tests only due to
 clearing help by `.entry-meta`. We get busted in an Aside when the last
 element is floated, since the background color doesn't wrap. If accepted,
 we should also add a word-wrap attribute and an override for image
 attachements.

 Both will probably need more testing then, too.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21740#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list