[wp-trac] [WordPress Trac] #21815: Integrate TinyMCE gallery views with the new media modal

WordPress Trac wp-trac at lists.automattic.com
Fri Oct 5 04:24:10 UTC 2012


#21815: Integrate TinyMCE gallery views with the new media modal
----------------------------+--------------------------
 Reporter:  koopersmith     |       Owner:  koopersmith
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  3.5
Component:  Gallery         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+--------------------------

Comment (by koopersmith):

 In [22120]:
 {{{
 #!CommitTicketReference repository="" revision="22120"
 Use the new media modal to insert galleries into TinyMCE and the text
 editor.

 '''Galleries'''

 * Gallery insertion from the new media modal (into TinyMCE, the text
 editor, etc).
 * Gallery previews in TinyMCE now use the `wp.mce.views` API.
 * Disables the TinyMCE `wpgallery` plugin.
 * Gallery previews consist of the first image of the gallery and the
 appearance of a stack. This will later be fleshed out to include more
 images/functionality (including editing the gallery, gallery properties,
 and showing the number of images in the gallery).
 * Multiple galleries can be added to a single post.
 * The gallery MCE view provides a bridge between the `wp.shortcode` and
 `Attachments` representation of a gallery, which allows the existing
 collection to persist when a gallery is initially created (preventing a
 request to the server for the query).


 '''Shortcodes'''

 * Renames `wp.shortcode.Match` to `wp.shortcode` to better expose the
 shortcode constructor.
 * The `wp.shortcode` constructor now accepts an object of options instead
 of a `wp.shortcode.regexp()` match.
 * A `wp.shortcode` instance can be created from a `wp.shortcode.regexp()`
 match by calling `wp.shortcode.fromMatch( match )`.
 * Adds `wp.shortcode.string()`, which takes a set of shortcode parameters
 and converts them into a string.* Renames `wp.shortcode.prototype.text()`
 to `wp.shortcode.prototype.string()`.
 * Adds an additional capture group to `wp.shortcode.regexp()` that records
 whether or not the shortcode has a closing tag. This allows us to improve
 the accuracy of the syntax used when transforming a shortcode object back
 into a string.

 '''Media Models'''

 * Prevents media `Query` models from observing the central
 `Attachments.all` object when query args without corresponding filters are
 set (otherwise, queries quickly amass false positives).
 * Adds `post__in`, `post__not_in`, and `post_parent` as acceptable JS
 attachment `Query` args.
 * `Attachments.more()` always returns a `$.promise` object.

 see #21390, #21809, #21812, #21815, #21817.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21815#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list