[wp-trac] [WordPress Trac] #20896: Theme Customizer: Add "no-customize-support" class to the body tag by default

WordPress Trac wp-trac at lists.automattic.com
Mon Oct 1 17:55:31 UTC 2012


#20896: Theme Customizer: Add "no-customize-support" class to the body tag by
default
------------------------------------+------------------------------
 Reporter:  kobenland               |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Appearance              |     Version:  3.4
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch dev-feedback close => has-patch dev-feedback


Comment:

 Replying to [comment:10 nacin]:
 > Adding no-customize-support by default is to handle flashes of should-
 be-hidden content before the JS in wp_customize_support_script() fires.
 Otherwise, content that is both .hide-if-customize and .hide-if-no-
 customize might appear by default, among other side effects.
 >
 > But, since "Customize" appears in a dropdown in the toolbar, and
 therefore hidden on load, we're not worried about a flicker, and can let
 the JS handle it.


 My intent is to allow for a graceful no-js fallback. no-js means no
 Customizer and it also means we can't rely on the JS to add the correct
 class for us. This is accounted for (unintentionally?) in the two other
 instances of Customizer links in the Dashboard because `no-customize-
 support` is added in admin-header.php. [attachment:20896.4.diff] adds the
 body class for the front-end.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20896#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list