[wp-trac] [WordPress Trac] #22559: Solve for incorrect uses of media_buttons_context

WordPress Trac noreply at wordpress.org
Fri Nov 23 23:18:25 UTC 2012


#22559: Solve for incorrect uses of media_buttons_context
--------------------------+--------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.5
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by nacin):

 * severity:  major => normal


Comment:

 That patch wil leave a stray </a> up front (which wasn't my intention),
 but it'll work, as it'll at least close the </a> at the end.

 And if a plugin was doing this:
 {{{
 add_filter( 'media_buttons_context', function( $str ) {
     return $str . ' </a> <a href="#">Insert Other Media</a>';
 } );
 }}}

 They'd have an extra </a>. But they also would have had an extra </a> to
 begin with.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22559#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list