[wp-trac] [WordPress Trac] #21990: SimplePie: DOMDocument can be disabled

[WordPress Trac]

#21990: SimplePie: DOMDocument can be disabled
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:
     Type:  defect (bug)                         |  markjaquith
 Priority:  low                                  |      Status:  assigned
Component:  External Libraries                   |   Milestone:  3.5
 Severity:  normal                               |     Version:  trunk
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by nacin):

 * keywords:  has-patch dev-feedback needs-testing needs-unit-tests => has-
     patch needs-testing needs-unit-tests
 * priority:  normal => low
 * severity:  blocker => normal


Comment:

 Nice work. In [22811], I tossed WP_SimplePie_Sanitize_KSES into the
 existing class-feed.php file where we already extend SimplePie_File,
 SimplePie_Cache, etc.

 Lowering priority and severity now that this is no longer critical under
 most situations.

 We still need to update SimplePie core to avoid calling DOMDocument when
 it is not available. A plugin using SimplePie directly (thus sidestepping
 fetch_feed()) will not be able to rely on kses, but they should still be
 given an opportunity to avoid the fatal error. My suggestion would be to
 pass an error back up the stack (if that makes sense — I'm not that
 familiar with SP) or just return `''`, as rmccue and I had discussed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21990#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software