[wp-trac] [WordPress Trac] #22356: Deprecate gd_edit_image_support() and replace it with a better method

WordPress Trac noreply at wordpress.org
Mon Nov 19 02:35:04 UTC 2012


#22356: Deprecate gd_edit_image_support() and replace it with a better method
--------------------------+--------------------
 Reporter:  markoheijnen  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  3.5
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------

Comment (by nacin):

 I think this function highlights two issues with WP_Image_Editor:

  * WP_Image_Editor_GD does not check if, individually, PNG, GIF, and JPEG
 can be supported. It assumes all can be supported. gd_edit_image_support()
 does not make that assumption. Is this a safe assumption to make and we
 were just being hyper-sensitive previously?

  * There doesn't appear to be a good way to check if a mime-type is
 supported by any of the image editors, which is what
 gd_edit_image_support() did, without actually loading the image.

  * It looks like supports_mime_type() isn't even considered in test(). I
 assumed it was.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22356#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list