[wp-trac] [WordPress Trac] #22189: Saving navigation menus is slow

WordPress Trac noreply at wordpress.org
Tue Nov 6 10:45:02 UTC 2012


#22189: Saving navigation menus is slow
--------------------------+-----------------------
 Reporter:  nacin         |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.5
Component:  Menus         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+-----------------------
Changes (by duck_):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:11 nacin]:
 > In [22235]:
 > {{{
 > #!CommitTicketReference repository="" revision="22235"
 > Optimize wp_update_nav_menu_item() for high performance. Only query
 items for a menu when we need them. Update items after updating its meta
 so the meta cache can be leveraged. see #22189.
 > }}}

 When `$menu_item_db_id` is zero `is_object_in_term()` will return a
 `WP_Error` and the newly created menu item will not be associated with the
 specified menu. attachment:22189.tax_input-on-create.diff skips
 `is_object_in_term()` if the call is not updating an existing menu item.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22189#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list