[wp-trac] [WordPress Trac] #20776: Improve callback verification while executing hooks

WordPress Trac wp-trac at lists.automattic.com
Tue May 29 13:57:35 UTC 2012


#20776: Improve callback verification while executing hooks
-------------------------+------------------------------
 Reporter:  ericlewis    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Plugins      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by nacin):

 I disagree with this. One of the best things we can do here is offer
 immediate and loud feedback to a developer in these cases. This is a
 developer error, not a user error. Issuing a warning should raise enough
 alarms without actually terminating execution flow.

 We've all made a typo in a callback, only to spend quite a bit of time
 figuring out what was going wrong. It's worse when the issue is not
 reflected in the logs.

 I'm actually not sure why the NULL check is there. I would rather remove
 it for both meager performance reasons and developer feedback reasons.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20776#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list