[wp-trac] [WordPress Trac] #20663: add_image_size needs a $label

WordPress Trac wp-trac at lists.automattic.com
Sat May 12 20:56:03 UTC 2012


#20663: add_image_size needs a $label
--------------------------+------------------------------
 Reporter:  wycks         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  3.3.2
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------
Changes (by SergeyBiryukov):

 * component:  General => Media


Old description:

> add_image_size() does not have a $label parameter, this effects both
> localization but more importantly limits the `image_size_names_choose`
> filter.
>
> The is when you try to add an image to a post and you can select sizes
> via the radio buttons.
>
> Default sizes have labels like:  'large' => __('Large')
>
> the `image_size_names_choose` filter is a great new filter that allows
> you to alter those radio buttons, but requires you to hardcore the array
> values for add_image_size() since it does not have a label (unless I'm
> missing something).
>
> Reference code: https://gist.github.com/2668630
>
> Related: http://core.trac.wordpress.org/ticket/19990

New description:

 add_image_size() does not have a $label parameter, this effects both
 localization but more importantly limits the `image_size_names_choose`
 filter.

 The is when you try to add an image to a post and you can select sizes via
 the radio buttons.

 Default sizes have labels like:  `'large' => __('Large')`

 the `image_size_names_choose` filter is a great new filter that allows you
 to alter those radio buttons, but requires you to hardcore the array
 values for add_image_size() since it does not have a label (unless I'm
 missing something).

 Reference code: https://gist.github.com/2668630

 Related: #19990

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20663#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list