[wp-trac] [WordPress Trac] #17863: HTML5 input type=number in admin settings

WordPress Trac wp-trac at lists.automattic.com
Sat Mar 10 01:19:55 UTC 2012


#17863: HTML5 input type=number in admin settings
----------------------------+------------------------------
 Reporter:  niallkennedy    |       Owner:  georgestephanis
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  3.4
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------------------

Comment (by azaozz):

 Revised the patch. Removing almost all type="url" as there's no need to
 limit most of these fields to absolute URLs. The only remaining is in
 options-media.php for "Full URL path to files" (when specifying alternate
 wp-content/uploads directory).

 In a nutshell:
 - All search fields changed to type="search" (no validation restrictions).

 - All fields that are for emails changed to type="email".

 - The following fields changed to type="number" step="1" min="1":
   - screen.php, screen options "per page",
   - options-discussion.php, "Break comments into pages...",
   - options-discussion.php, "Hold a comment in the queue if it contains %s
 or more links",
   - options-media.php, all fields for setting thumbnail, medium and large
 sizes for images,
   - options-media.php, both fields for setting "embed size" for auto-
 embedded videos,
   - options-reading.php, "posts_per_page" and "posts_per_rss",
   - class-wp-list-table.php, "Current page", also removed the `esc_attr(
 'paged' )` from there, no point in escaping a hard-coded ASCII string.

 - The "Automatically close comments on articles older than..." field in
 options-discussion.php changed to type="number" step="1" min="0".

 - The "Site Upload Space Quota" field in ms.php changed to type="number"
 step="0.1" min="0".

 - The year, day, hour, minute fields in template.php changed to validate
 the corresponding numbers, i.e. for day: type="number" step="1" min="1"
 max="31".

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17863#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list