[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by jorbin):

 Replying to [comment:119 TomAuger]:
 > Okay, scrolling up, I'm noticing some unanswered issues / questions
 needing decisions. In an effort to hopefully bring us closer to some
 decisions, let me just summarize them here and see if we can get some
 consensus.
 >
 > 1. .ICO or not? If we don't support .ico at all, Explorer is out, so
 this doesn't seem like an option to me. So either we allow straight by-
 pass upload of an .ico file, or we figure out how to encode the .ico
 bytestream by either scavenging from sources we currently have or
 leveraging another library since GD doesn't support it natively.

 I think we need to.  The library is a mess though and I think including it
 as-is is a bad idea.  I would rather not include this in the release then
 include that library right now.
 >
 > 2. _media_states() not sure I understand what this is or how it's
 relevant. Looking for a little guidance on that one.
 We should include it in that function so that the image is properly marked
 as the favicon.

 >
 > 3. Should we delete the original image after cropping and saving the
 32x32 sized thumbs? Or do we leave the full-size attachment in the
 library? Do we also let it create all the other registered thumbnail sizes
 for the attachment?

 My first thought is that we should treat it the same way as an image
 uploaded for the custom background and custom header.  If we create the
 thumbnails for those, we should create the thumbnail for this.

 >
 > 4. Thickbox or not for the crop UI?

 Not Thickbox, but also having the user leave the page seems like bad UX to
 me. The more I think about it, the more I think an iframe inline is going
 to be the best approach.

 >
 > 5. Location of the actual favicon field in Settings > General (see my
 comments on why it's currently on top). If we're not putting it on top (or
 bottom) then I'm looking for some creative suggestions to how to shim it
 into the page within the current form.

 Not sure on this one.


 Overall, I think we might be best developing this as a plugin that we can
 then bring in early in 3.5 rather then trying to force this into 3.4.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:120>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software