[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by TomAuger):

 Replying to [comment:106 azaozz]:
 > Few more things while testing 16434.2.diff:
 thanks for the testing!


 > - When uploading a "favicon.ico" file, it's uploaded but is not set as
 favicon. Instead there's the error: "Please only use PNG (.png), JPEG
 (.jpg) or BMP (.bmp) image files for favicons." (this statement is wrong
 by itself).
 Okay, I'll revise the front-end filter for now to only accept PNG and JPG,
 and make sure the error message reflects that.


 > - When uploading an already resized 32x32 image it still goes to the
 crop screen, would probably be better to skip that step and set the image
 directly as favicon, converting it to .png if needed.
 I'll perform a check on the uploaded size and if it's equal to or less
 than the default favicon size (as set by the 'favicon-size' filter), then
 skip the crop step.

 > - The UI on the General Settings screen should probably be after "E-mail
 Address" or at the bottom. Having it at the top doesn't "feel right".
 I'm happy to put it anywhere, however, the rationale for its position is
 twofold:
 1. Because the favicon appears near the site title in the browser tab, and
 because the topmost items under Settings > General are all related to the
 actual website itself (as opposed to the primary user, the timezone, etc),
 it seems to me that the favicon is most logically grouped there. Also,
 since it's one of the "flashier" bits of that particular page, there's a
 certain marketing appeal.

 2. More importantly, from a dev perspective, the rest of the page is
 wrapped in a FORM tag, and FORM tags can't be nested, so I'd either have
 to break the settings > general form tag, insert the favicon form, open a
 new form tag after it (which just seems crazy), or do something more
 sneaky like use an iFrame, which has its own issues. Now, if we do move
 forward with the iFrame approach for the crop section as you suggest
 (though that seems problematic to me, see below) then this could be a
 natural possibility.

 I'll defer that decision until I get more feedback on the matter. Perhaps
 others can weigh in here.

 > Also using thickbox wouldn't be advisable. There are plans for scrapping
 thickbox and modal dialogs in general. Perhaps better would be to insert
 an iframe right under the UI on the General Settings screen.
 The only issue I can see with this is that the crop UI is really (really)
 large at the moment, though arguably we could make the whole thing a bit
 smaller (though I wouldn't want to go less than 300x300 for the image
 size). So that's a pretty big chunk of real estate to just insert smack in
 the middle of the rest of the Settings > General form. Unless I'm not
 properly understanding your suggestion?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:109>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software