[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

WordPress Trac wp-trac at lists.automattic.com
Thu Mar 1 11:10:33 UTC 2012


#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by ocean90):

 Just my 2 cents:

  - `echo <<<` ... do we really want this?
  - instead of FAVICON_SIZE I would prefer `apply_filters( 'favicon_size',
 32 )`
  - Because the image will be uploaded to the media library, the image
 should be marked, see `_media_states`
  - If I delete the favicon from the media library the options should get
 reset accordingly (like for theme mods `_delete_attachment_theme_mod`)
  - And should we delete the original image after cropping?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:97>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list