[wp-trac] [WordPress Trac] #21093: wp_unique_term_slug() & Custom Post Type / Page Slugs Comparison

[WordPress Trac]

#21093: wp_unique_term_slug() & Custom Post Type / Page Slugs Comparison
--------------------------+------------------------
 Reporter:  wpsmith       |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Taxonomy      |     Version:  3.4
 Severity:  normal        |  Resolution:  duplicate
 Keywords:  has-patch     |
--------------------------+------------------------
Changes (by coffee2code):

 * keywords:  has-patch dev-feedback 2nd-opinion => has-patch
 * status:  new => closed
 * version:   => 3.4
 * resolution:   => duplicate
 * milestone:  Awaiting Review =>


Comment:

 You went a little around the block at first with the description so I
 didn't know what you were getting at until the patch. I'm going to close
 this as a dupe of #20783. I amended the existing patch there to
 incorporate your suggestion of the *_is_bad_* filters to better align with
 `wp_unique_post_slug()`. I corrected the incorrect logic in your patch
 where the first `wp_unique_is_bad_term_slug` filter was concerned (and
 changed it to be `wp_unique_term_slug_is_bad_hierarchical_slug` as is the
 case for the post version). That ticket already proposed the
 `wp_unique_term_slug` filter, and also adds a `pre_wp_unique_term_slug`.

 Feel free to continue discussion there.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21093#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software