[wp-trac] [WordPress Trac] #21092: Media uploader insert button doesn't respect the current post type

WordPress Trac wp-trac at lists.automattic.com
Thu Jun 28 04:07:06 UTC 2012


#21092: Media uploader insert button doesn't respect the current post type
-------------------------+------------------------------
 Reporter:  evansolomon  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Media        |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by johnbillion):

 The approach in your patch works fine in English, but it's not suitable
 for l10n. We can't simply pass the post type name as a parameter to
 `sprintf()` because in some languages the phrase "Insert into [post_type]"
 will differ depending on the post type.

 We'll need to introduce a new post type label, probably called
 `insert_into_post`, and use that. See #19257 for an example of a patch
 which introduces a new post type label.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21092#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list