[wp-trac] [WordPress Trac] #20831: Remove unused variable from wp_update_themes()

WordPress Trac wp-trac at lists.automattic.com
Mon Jun 18 18:48:19 UTC 2012


#20831: Remove unused variable from wp_update_themes()
--------------------------+------------------
 Reporter:  duck_         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.5
Component:  General       |     Version:  3.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by nacin):

 * milestone:  Future Release => 3.5


Comment:

 Because we do `$new_update->checked = $checked;`, indeed, this is not
 needed.

 Plugins does `$new_option->checked[ $file ] = $p['Version'];` but that is
 because $checked is not simply plugin => version, it is plugin => data. We
 should probably make these two functions behave exactly the same at some
 point, perhaps even merging them.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20831#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list