[wp-trac] [WordPress Trac] #20448: Update Twenty Ten and Twenty Eleven to use 3.4 features

[WordPress Trac]

#20448: Update Twenty Ten and Twenty Eleven to use 3.4 features
----------------------------+--------------------------
 Reporter:  nacin           |       Owner:  koopersmith
     Type:  task (blessed)  |      Status:  reopened
 Priority:  high            |   Milestone:  3.4
Component:  Bundled Theme   |     Version:  3.4
 Severity:  major           |  Resolution:
 Keywords:  has-patch       |
----------------------------+--------------------------

Comment (by nacin):

 Okay, let's bury the idea that, if un-saved defaults are in place, there
 should be no <style> block printed. This hurts themes that used
 BACKGROUND_IMAGE without specifying a fallback in the stylesheet, and they
 did that because otherwise removal wouldn't work.

 [attachment:20448.8.diff] reverts wp-includes for [20973] and then makes
 some adjustments:
  * <style> will appear if there is a default image registered. This is the
 same as 3.3.
  * If only a default color is registered, it still assumes it is in the
 stylesheet, and no <style> will appear. This is a change from 3.3.
  * <style> will continue to appear as before if there is a custom
 background color or image. This is the same as 3.3.
  * This then allows for a default background image with background-image:
 none, overriding style.css. This is new.

 The goals of [20973] were to make default-image and default-color not
 suck, thus encouraging their use, since they're basically new in 3.4.* But
 at the same time we don't want to encourage people to stop putting these
 things in CSS '''as well'''. We simply want them to register it with
 WordPress so we know.

 (*) I consider them new because:
  * They are now first-class arguments, rather than second-class constants.
 People will notice them.
  * The constants did not work well, as they could not be removed, were not
 part of the preview, and were not represented in the UI.
  * The default themes are now leveraging them.

 This does not fix comment 15.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20448#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software