[wp-trac] [WordPress Trac] #20813: _get_plugin_data_markup_translate fails to load plugin translations

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 1 21:41:36 UTC 2012


#20813: _get_plugin_data_markup_translate fails to load plugin translations
-------------------------------------------------+-------------------------
 Reporter:  arnee                                |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  I18N                                 |  Release
 Severity:  normal                               |     Version:  2.9
 Keywords:  has-patch dev-feedback needs-        |  Resolution:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by nacin):

 * severity:  major => normal
 * milestone:  3.4 => Future Release


Comment:

 Core calls get_plugin_data() in a few different ways. When it calls it
 with $translate = true, this won't work — as an absolute $plugin_file is
 passed to _get_plugin_data_markup_translate(), and it fails.

 But when core calls _get_plugin_data_markup_translate() in the plugins
 list table, it does it with a *relative* $plugin_file argument. So it
 works on plugins.php.

 So, while there is definitely a bug here, it will need to account for both
 relative and absolute paths, or we need to have
 _get_plugin_data_markup_translate() always receive relative paths.

 But, what's the indication of a bug? Core displays the translation just
 fine on plugins.php. Seems like it would only affect the bulk upgrader.
 Kicking this to future release as there is no immediate breakage.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20813#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list